Skip to end of metadata
Go to start of metadata

[11:14:20 CDT(-0500)] <Bosmon> yura

[11:14:29 CDT(-0500)] <Bosmon> a PENGUINE suggested that at least we two should check in : P

[11:14:33 CDT(-0500)] <Bosmon> Did you resolve your EL parsing issue?

[11:14:42 CDT(-0500)] <yura> Bosmon: yes

[11:14:46 CDT(-0500)] <Bosmon> Awesome

[11:14:51 CDT(-0500)] <yura> it was the . that i did not see

[11:14:57 CDT(-0500)] <Bosmon> (smile)

[11:15:04 CDT(-0500)] <Bosmon> Dots before your eyes

[11:16:28 CDT(-0500)] <yura> Bosmon: just for you I opened an early pull request (smile) so you can leave some early feedback (smile)

[11:17:43 CDT(-0500)] <Bosmon> Now I see it

[11:17:46 CDT(-0500)] <Bosmon> Let me take a look

[11:17:55 CDT(-0500)] <yura> most of it doesnt work

[11:18:06 CDT(-0500)] <yura> but it has a lot of sketches of how it will look like

[11:23:54 CDT(-0500)] <yura> Bosmon: so what do you think ?

[11:24:11 CDT(-0500)] <Bosmon> yura - it looks harmless enough (smile)

[11:24:52 CDT(-0500)] <Bosmon> I'm puzzled why the OntologyServer is written in MatchMaker.js rather than in its own file

[11:24:55 CDT(-0500)] <Bosmon> that.get = function (termMap, callback) {

[11:25:04 CDT(-0500)] <Bosmon> Could this line perhaps be written using PROMMISSES?

[11:25:27 CDT(-0500)] <yura> ya it could, but i m not sure if we are starting to do this this way everywhere

[11:25:38 CDT(-0500)] <yura> it's not really a ontologyserver

[11:25:46 CDT(-0500)] <yura> the only reason it would work if i put it there

[11:26:33 CDT(-0500)] <yura> is because our init script loads everything

[11:28:07 CDT(-0500)] <yura> but i see what you are saying, given that i m using some global function from ontology module anyways i should probably move it there

[11:28:13 CDT(-0500)] <Bosmon> Yes

[11:28:21 CDT(-0500)] <Bosmon> It definitely deserves to be a major new top-level module

[11:28:44 CDT(-0500)] <yura> oh and another thing colinclark mentioned

[11:28:59 CDT(-0500)] <yura> you see how there are composite events on match POST ?

[11:28:59 CDT(-0500)] <colinclark> uh oh

[11:29:05 CDT(-0500)] <colinclark> did i say something dumb again?

[11:29:06 CDT(-0500)] <colinclark> (tongue)

[11:29:20 CDT(-0500)] <Bosmon> colinclark - isn't this what you meant by checking in? : P

[11:29:27 CDT(-0500)] <colinclark> yes (smile)

[11:29:32 CDT(-0500)] <Bosmon> good good

[11:29:36 CDT(-0500)] <colinclark> I just saw yura saying I mentioned something

[11:29:41 CDT(-0500)] <colinclark> and usually it's something dumb (tongue)

[11:29:41 CDT(-0500)] <yura> hah colinclark the opposite (from our last week chat)

[11:29:56 CDT(-0500)] <Bosmon> Oh yes I see it now

[11:30:05 CDT(-0500)] <colinclark> yura: can you point me to a link?

[11:30:08 CDT(-0500)] <yura> Bosmon: the event listeners should be probably global strategies that could be configurable by the contributor as well

[11:30:09 CDT(-0500)] <colinclark> with your compound events?

[11:30:12 CDT(-0500)] <yura> and another thing

[11:30:17 CDT(-0500)] <yura> colinclark: sure

[11:30:45 CDT(-0500)] <yura> colinclark: https://github.com/yzen/universal/blob/GPII-43/gpii/node_modules/matchMaker/src/MatchPost.js

[11:31:03 CDT(-0500)] <yura> or rather https://github.com/yzen/universal/blob/GPII-43/gpii/node_modules/matchMaker/src/MatchPost.js#L32-40

[11:31:28 CDT(-0500)] <colinclark> ah yes

[11:32:07 CDT(-0500)] <yura> so Bosmon, colinclark pointed out another thing, the issue with our matchmaking strategy and its current constraint with its arguments

[11:32:24 CDT(-0500)] <colinclark> oh yes

[11:32:31 CDT(-0500)] <Bosmon> yura - yes

[11:32:40 CDT(-0500)] <Bosmon> And I think this also relates to a point that has come up a few times before

[11:32:43 CDT(-0500)] <colinclark> the fact that strategies are only given leaves

[11:32:47 CDT(-0500)] <yura> oh and another thing, on the side, we need to somehow fix the jqunit issue, it really is problematic at this point

[11:32:51 CDT(-0500)] <Bosmon> THe fact that we currently have no way to encode demands blocks in our configuration files

[11:33:04 CDT(-0500)] <colinclark> that would so great, Bosmon

[11:33:05 CDT(-0500)] <Bosmon> Perhaps it is time to attend to that

[11:33:13 CDT(-0500)] <Bosmon> Since right now our configurations still aren't self-contained

[11:33:26 CDT(-0500)] <colinclark> I showed yura's new config files to people today

[11:33:26 CDT(-0500)] <Bosmon> Each one of them depends not only on the configuration file, but also on some hard-coded demands

[11:33:30 CDT(-0500)] <colinclark> and everyone was stunned

[11:33:36 CDT(-0500)] <colinclark> like "wow, it can do that?"

[11:33:39 CDT(-0500)] <Bosmon> yura - which jqunit issue do you mean?

[11:33:52 CDT(-0500)] <colinclark> or rather, "we can do that?"

[11:34:02 CDT(-0500)] <yura> Bosmon: that running sync tests is broken

[11:34:05 CDT(-0500)] <yura> only 1 test runs

[11:34:07 CDT(-0500)] <Bosmon> yura - ah, that one

[11:34:08 CDT(-0500)] <yura> always

[11:34:11 CDT(-0500)] <Bosmon> ok

[11:34:20 CDT(-0500)] <Bosmon> I'll try to get to that this week

[11:34:40 CDT(-0500)] <colinclark> "that," Bosmon?

[11:34:50 CDT(-0500)] <colinclark> the test issue?

[11:34:51 CDT(-0500)] <Bosmon> sync tests

[11:34:53 CDT(-0500)] <yura> Bosmon: would be great since i m asking Ross to write tests for json settings handler and i m afraid he ll get confused

[11:35:15 CDT(-0500)] <colinclark> i know we don't have a ton of time...

[11:35:30 CDT(-0500)] <colinclark> but do you think we look jerky if we just say "can you write tests for this?"

[11:35:41 CDT(-0500)] <colinclark> i guess we sent him some example tests, right?

[11:35:56 CDT(-0500)] <yura> colinclark: ya i think i gave him enough feedback for now

[11:36:02 CDT(-0500)] <yura> pointing here and there

[11:36:32 CDT(-0500)] <colinclark> cool

[11:36:36 CDT(-0500)] <colinclark> that sounds good to me

[11:37:37 CDT(-0500)] <Bosmon> So what had colinclark said about compound events?

[11:38:25 CDT(-0500)] <colinclark> yura: ^

[11:39:35 CDT(-0500)] <yura> Bosmon: oh, basically that these events in time should be publicized and organized as a strategy, perhaps, so it could be configurable from outside

[11:39:44 CDT(-0500)] <yura> just like we have our strategy for matchmaking

[11:40:01 CDT(-0500)] <Bosmon> ok

[11:41:03 CDT(-0500)] <yura> Bosmon: i think what you said about declarative demands should probably part of the separate pull request

[11:41:10 CDT(-0500)] <yura> be*

[11:41:29 CDT(-0500)] <Bosmon> yura - yes

[11:43:48 CDT(-0500)] <yura> Bosmon: so would you leave a comment for me once you are done with taking a look, unless you are done (smile) ?

[11:44:00 CDT(-0500)] <Bosmon> ok, thanks yura

[15:52:50 CDT(-0500)] <yura> Bosmon: ayt?

  • No labels