Skip to end of metadata
Go to start of metadata

[08:23:51 CST(-0600)] <jessm> 'morning everyone

[08:31:04 CST(-0600)] <anastasiac> jameswy, jessm, good morning. You probably saw avtar's email that the ildh site has been upgraded. This means we have much better control over the sizes of images (e.g. see the mind map on the Inclusive learning page). We should all keep a close eye for any possible problems with the upgrade, but I think we're in good shape

[08:31:24 CST(-0600)] <anastasiac> I'm going to go back over some of the images I added yesterday which are too large, and resize them appropriately now that thumbnails are supported.

[08:31:45 CST(-0600)] <jameswy> Thanks, anastasiac

[08:31:45 CST(-0600)] <anastasiac> if there's anything else I can help with in particular, let me know

[08:41:59 CST(-0600)] <jessm> jameswy: what's our break-down

[08:42:02 CST(-0600)] <jessm> do you want to check in

[08:42:06 CST(-0600)] <jessm> anastasiac: thanks re: images

[08:42:13 CST(-0600)] <jessm> the embedded slideshare is working great too

[08:42:32 CST(-0600)] <jameswy> jessm: Sure, let's check in.

[08:42:41 CST(-0600)] <anastasiac> yes, avtar added the necessary plug-in for that - it looks great. The size can be adjusted, if you like, jessm

[08:42:58 CST(-0600)] <jessm> anastasiac: what do you think? a little bigger?

[08:43:58 CST(-0600)] <anastasiac> you know, I don't actually think so. Most of the text is plenty big enough (i.e. bigger than the text on the page) and there is a link to the original presentation if necessary

[08:44:05 CST(-0600)] <anastasiac> I wonder what UIO does to it… hm...

[08:44:14 CST(-0600)] <anastasiac> no effect

[08:44:30 CST(-0600)] <anastasiac> that's reasonable, I guess. It treats it like an image

[08:59:05 CST(-0600)] <jameswy> cindyli: When you get a chance, could you change "Body/techniques/something?" to simply "Techniques" on the ILDH?

[08:59:28 CST(-0600)] <cindyli> sure, jameswy

[08:59:37 CST(-0600)] <jameswy> Thanks!

[08:59:41 CST(-0600)] <cindyli> np

[09:00:30 CST(-0600)] <anastasiac> avtar, we had originally planned for the "development" branch of the handbook to be deployed to a development site so that we could work and share before deploying to the production site. We do have a dev site (dev.handbook…), but it doesn't seem to be reflecting the development branch, which at the moment should be the same as master. We're hoping to do some styling work this afternoon, which we should do on the development branch unt

[09:00:30 CST(-0600)] <anastasiac> we're happy. Is there any way we can set this up?

[09:01:45 CST(-0600)] <avtar> sure, i'll take a look at which vm is hosting that server

[09:23:54 CST(-0600)] <Justin_o> yura: quick IoC question.. can i set a listener for an event using IoC, with one of the components inovkers

[09:24:27 CST(-0600)] <yura> as long as you know it's created by the time your listener is being registered

[09:24:59 CST(-0600)] <Justin_o> yura: thanks.. it should be, but doesn't seem to be working

[09:25:08 CST(-0600)] <yura> so in other words we cant put in components defaults a listener that refers to the same components invoker

[09:26:02 CST(-0600)] <Justin_o> yura: so i had one that registered to an event that fires on a click, but in the unit tests it doesn't get triggered

[09:26:09 CST(-0600)] <Justin_o> if i just use a straight function it works though

[09:26:14 CST(-0600)] <Justin_o> so the event works

[09:26:30 CST(-0600)] <yura> ohh

[09:26:30 CST(-0600)] <yura> ya

[09:26:41 CST(-0600)] <yura> so it would work if you wrap it in anonumous function i think

[09:26:44 CST(-0600)] <yura> i saw that issue

[09:26:50 CST(-0600)] <yura> and i believe there might be a bug somewhere

[09:27:16 CST(-0600)] <Justin_o> yura: okay, but i won't be able to get access to the components invoker that way can I?

[09:27:40 CST(-0600)] <yura> hmm

[09:30:00 CST(-0600)] <avtar> anastasiac: could you please try again when you have a chance

[09:31:18 CST(-0600)] <anastasiac> ah, excellent, avtar, much better. Is this just deploying from a separate folder of the handbook, i.e. we could make this site reflect any branch we wanted to?

[09:37:14 CST(-0600)] <avtar> anastasiac: this instance of mediawiki was cloned from the development branch into a separate directory on the server

[09:37:55 CST(-0600)] <avtar> i'm seeing a permissions error

[09:37:56 CST(-0600)] <avtar> one sec

[09:39:05 CST(-0600)] <cindyli> anastasiac, avtar, do you notice that accessing page throws a js error - $.client is undefined

[09:40:31 CST(-0600)] <anastasiac> yes, cindyli, I'm seeing that. Not sure where it's happening, though - not Infusion. Have you seen anything not working right?

[09:41:19 CST(-0600)] <cindyli> no, anastasiac, i was just clicking around. The content looks good

[09:41:40 CST(-0600)] <cindyli> although the js error at each page refresh is a bit annoying (wink)

[09:43:44 CST(-0600)] <anastasiac> yeah, cindyli. weird. I can't find that string ("$.client") anywhere in any file...

[09:51:31 CST(-0600)] <cindyli> umm.. anastasiac, i found the string in some of the mediaWiki js files and its built-in jquery files. but it would be hard for us to fix it since we don't have much knowledge of mediaWiki code structure

[09:52:13 CST(-0600)] <anastasiac> cindyli, I agree - we don't want to be adjusting mediawiki. I'm curious: which files?

[09:52:56 CST(-0600)] <cindyli> oh, a few: extensions/Vector/modules/ext.vector.collapsibleNav.js

[09:53:07 CST(-0600)] <cindyli> extensions/Vector/modules/ext.vector.expandableSearch.js

[09:53:16 CST(-0600)] <cindyli> extensions/Vector/modules/ext.vector.simpleSearch.js

[09:53:50 CST(-0600)] <cindyli> WikiEditor/modules/jquery.wikiEditor.iframe.js

[09:53:59 CST(-0600)] <cindyli> WikiEditor/modules/jquery.wikiEditor.js

[09:54:27 CST(-0600)] <cindyli> and a few other files in directory: resources/jquery

[09:54:38 CST(-0600)] <cindyli> and resources/mediawiki

[09:55:25 CST(-0600)] <michelled> cindyli, alexn: I'm tempted to push Bosmon's branch to demo. There are issues with it - the controllers tests are broken and there are some bugs in the interaction of the media settings with the video player

[09:55:39 CST(-0600)] <michelled> but overall the code looks good and the video player behaves better

[09:55:52 CST(-0600)] <michelled> cindyli, alexn: what do you think?

[09:55:56 CST(-0600)] <cindyli> no objection, michelled

[09:57:07 CST(-0600)] <avtar> anastasiac, cindyli:

[09:57:59 CST(-0600)] <alexn> michelled, cindyli: I guess depends on the size of those bugs you mentioned. If things are not getting broken too much then we could give it a shot.

[09:58:00 CST(-0600)] <avtar> not a lot of info out there besides that post

[09:59:13 CST(-0600)] <michelled> alexn: as I said, overall, things are actually working better

[09:59:24 CST(-0600)] <michelled> the bugs are related to the new functionality that he introduced

[09:59:43 CST(-0600)] <michelled> the interaction between the media settings panel in UIO and the video player

[10:02:45 CST(-0600)] <michelled> also, the new functionality hasn't been added to the plain VideoPlayer.html demo

[10:02:52 CST(-0600)] <cindyli> avtar: I've pushed a change into to apply jameswy's request on changing a navigation item title. Can you do a "git fetch origin" on production server since I kept getting permission error

[10:03:06 CST(-0600)] <cindyli> the error i got: cindy@xen0:/var/www/$ git fetch origin

[10:03:06 CST(-0600)] <cindyli> error: cannot open .git/FETCH_HEAD: Permission denied

[10:03:30 CST(-0600)] <cindyli> it seems reasonable since .git/FETCH_HEAD is owned by root. no complaint

[10:04:29 CST(-0600)] <avtar> cindyli: do you want to give it another shot?

[10:13:00 CST(-0600)] <jessm> anastasiac: can you check into text descriptions for links in the ILDH – or even just captioning all our images

[10:13:39 CST(-0600)] <anastasiac> jessm, I believe all of the images already have captions, but I'll double-check everything, and make sure they've all got something

[10:13:48 CST(-0600)] <jessm> cool-io, thanks

[10:15:59 CST(-0600)] <avtar> anastasiac: do you have a pgp key?

[10:16:16 CST(-0600)] <anastasiac> yes, avtar, I believe I do

[10:16:35 CST(-0600)] <avtar> could i get the public one from you?

[10:16:42 CST(-0600)] <anastasiac> looking for it

[10:16:44 CST(-0600)] <avtar> ok

[10:17:13 CST(-0600)] <anastasiac> avtar, that's the content of the "" file, right?

[10:18:33 CST(-0600)] <avtar> no, that's a ssh key

[10:18:39 CST(-0600)] <avtar>

[10:18:55 CST(-0600)] <anastasiac> k, I'll make one

[10:19:28 CST(-0600)] <avtar> then i can send the files you requested using skype or dropbox

[10:20:46 CST(-0600)] <anastasiac> avtar, my mac has never heard of the gpg command - is that something I have to download?

[10:21:02 CST(-0600)] <avtar> yes

[10:21:06 CST(-0600)] <avtar> i normally install it using macports

[10:21:26 CST(-0600)] <avtar> if it's too much trouble i'll get them over to you another way

[10:21:52 CST(-0600)] <anastasiac> no, no trouble. I just find out what to do, and do it

[10:23:18 CST(-0600)] <cindyli> thanks, avtar, works like a charm

[10:23:26 CST(-0600)] <avtar> anastasiac: theres's this option as well if you don't have macports installed

[10:23:49 CST(-0600)] <cindyli> jameswy: the title change on "Techniques" title has been deployed.

[10:24:13 CST(-0600)] <anastasiac> right, avtar, I saw that one

[11:15:54 CST(-0600)] <anastasiac> jessm, all the images have captions, and I've added official alt text, for good measure

[11:16:04 CST(-0600)] <anastasiac> is there anything else I can help with?

[11:20:45 CST(-0600)] <jessm> anastasiac: thanks muchly

[11:21:01 CST(-0600)] <jessm> anastasiac: i thought you and jameswy were going to talk "sexy"

[11:21:08 CST(-0600)] <anastasiac> yep - after lunch

[11:21:10 CST(-0600)] <jessm> did you two do that? styling changes?

[11:21:12 CST(-0600)] <jessm> ah, after lunch

[11:21:13 CST(-0600)] <jessm> ok

[11:21:17 CST(-0600)] <jessm> that's the next thing

[11:21:31 CST(-0600)] <anastasiac> excellent!

[11:21:37 CST(-0600)] <alexn> michelled, cindyli: Here is the branch with transcript styling. It is definitely and improvement already and I think we can push it to the demo branch. Could you please take another look into it before we push it.

[11:21:52 CST(-0600)] <alexn> once it is there jvass would be able to give us more feedback

[11:21:52 CST(-0600)] <jameswy> jessm: Less "sexy", more "acceptable"

[11:22:01 CST(-0600)] <jessm> yes

[11:22:34 CST(-0600)] <jameswy> anastasiac: What's the URL for uploads again?

[11:22:43 CST(-0600)] <anastasiac> Special:Uploads

[11:22:48 CST(-0600)] <anastasiac> after index.php/

[11:23:26 CST(-0600)] <michelled> alexn: why do you require the !important for fl-videoPlayer-transcript-element-highlight?

[11:23:43 CST(-0600)] <michelled> any time we use important we make UIO's job and implementor overrides more difficult

[11:23:55 CST(-0600)] <jameswy> Thanks!

[11:25:12 CST(-0600)] <alexn> michelled: basically when you hover mouse over the text in the transcript it should change the color. But the selected block (the one which is currently playing in the videoPlayer) should have highlighted styling and should be excluded from this hover css styling

[12:58:26 CST(-0600)] <Justin_o> Bosmon: hello, i'm having a bit of trouble with getting some subcomponents to instantiate.. there are 3 versions of the same component.. they will have different options specified later.. Anyways, they all use the same type of markup.. there are three different containers, each with there own copy of the markup needed. the problem is that i'm getting an error because these components have subcomponents that are failing because there contai

[12:58:26 CST(-0600)] <Justin_o> isn't unique.. it finds 3, but shouldn't these be scoped to the parent container?

[12:59:12 CST(-0600)] <Justin_o> I tried looking through the code but so far it looks like the container is looked for globally in the document and isn't scoped to anything.. i'm assuming i'm missing something here, but not sure what.

[12:59:21 CST(-0600)] <Justin_o> let me know if I can clarify any of that for you

[13:05:24 CST(-0600)]

<Justin_o> Bosmon: it's okay, I think I figured it out. I had to use "

Unknown macro: {componentName}

.dom.seletor" when specifying the container in the defaults .. i had been using "


[13:58:11 CST(-0600)] <Justin_o> yura: have you run across any issues with demands for events.. i'm seeing now that if i do something like

[13:58:11 CST(-0600)] <Justin_o> fluid.demands("testModel", ["decapod.test", "decapod.exportType.pdfOptions"], [

[13:58:12 CST(-0600)]

<Justin_o> "

Unknown macro: {pdfOptions}


[13:58:12 CST(-0600)]

<Justin_o> "

Unknown macro: {arguments}


[13:58:12 CST(-0600)] <Justin_o> ]);

[13:58:38 CST(-0600)] <Justin_o> the second arguments is a copy of the new first argument, instead of it being the original first arguement

[13:59:52 CST(-0600)] <yura> Justin_o: no i have not, but i would make a test case for Antranig

[14:01:08 CST(-0600)] <Justin_o> yura: yah i was just looking to see if there was one that existed already

[14:10:39 CST(-0600)] <cindyli> michelled: I have a branch for enlarging the mammal demo videos, can you have a glance to make sure nothing weird? Thanks

[14:10:44 CST(-0600)] <cindyli>

[14:12:17 CST(-0600)] <michelled> cindyli: I love that you've cleaned up these style names (smile)

[14:12:20 CST(-0600)] <michelled> they'd been bugging me

[14:12:28 CST(-0600)] <cindyli> same to me (smile)

[14:14:59 CST(-0600)] <alexn> michelled, cindyli: does it mean that if this branch makes its way into the demo one, I can be free and move over to CSpace ? (smile)

[14:15:11 CST(-0600)] <michelled> yep (smile)

[14:15:54 CST(-0600)] <michelled> alexn: I thought you mentioned something about fixing the click through for captions - did you manage to get that in?

[14:16:30 CST(-0600)] <michelled> cindyli, alexn: some things regressed with the merge of Bosmon's branch. I'm trying to figure out the extent of it

[14:16:39 CST(-0600)] <michelled> if you notice something please let me know

[14:16:46 CST(-0600)] <alexn> michelled: checked the code and it is there in the css file

[14:17:01 CST(-0600)] <michelled> alexn: it doesn't seem to work though

[14:17:26 CST(-0600)] <cindyli> michelled: sure, if i noticed something

[14:17:36 CST(-0600)] <alexn> michelled: I'm on the demo branch and it works for me. I will ask Cindy to test it as well

[14:17:45 CST(-0600)] <michelled> alexn, cindyli: do you still need resizeHandler? it doesn't look like it's being used anywhere

[14:18:23 CST(-0600)] <cindyli> yes, u r right. we are double checking

[14:20:44 CST(-0600)] <alexn> michelled, just checked on the Cindy's computer and clicking on captions would pause/resume video. Also tested it in Chrome and it works for me

[14:21:08 CST(-0600)] <michelled> weird - maybe my browser is caching something

[14:21:25 CST(-0600)] <alexn> michelled: could you please refresh and try it again ?

[14:21:32 CST(-0600)] <cindyli> good finding, michelled, resizeHandler() is cleaned up and pushed. refresh your compare link please.

[14:22:07 CST(-0600)] <michelled> thx cindyli

[14:22:12 CST(-0600)] <michelled> alexn: it still didn't work

[14:22:14 CST(-0600)] <michelled> want to see?

[14:26:58 CST(-0600)] <alexn> michelled: good find. no idea how it worked for me and Cindy. But it is exactly what I was thinking. there is a div which overlaps with caption div a bit at the bottom. When you click on this overlapping clicks do not go through

[14:28:21 CST(-0600)] <michelled> ah, that explains it alexn

[14:28:38 CST(-0600)] <alexn> michelled: no worries it should be a quick fix though (smile)

[14:32:20 CST(-0600)] <alexn> or maybe…not so quick (big grin)

[14:57:09 CST(-0600)] <alexn> Bosmon, michelled: I noticed a very odd behaviour today in the code. Apparently in the Mammals demo captions are ON even thought the videoPlayer has set them to OFF. It seems like a timing issue when options might not be merged at the proper time since if you set a breakpoint in html5Captinator code, the page will work as expected.

[14:57:21 CST(-0600)] <alexn> original videoPlayer demo does not have this effect

[14:58:22 CST(-0600)] <alexn> I was trying to find any code which is missing or different between these 2 pages

[14:59:11 CST(-0600)] <alexn> only one thing strikes immediately that we are using a relay component in our Mammals demo

[14:59:54 CST(-0600)] <alexn> Bosmon do you have any idea what could possibly be a reason for this odd behaviour in the Mammals demo page ? (sad)

[15:03:22 CST(-0600)] <michelled> alexn: I'm able to reproduce the issue but I'm not sure what's causing it

[15:04:51 CST(-0600)] <Bosmon> alexn - there could be some cause....

[15:05:00 CST(-0600)] <alexn> (smile)

[15:05:04 CST(-0600)] <Bosmon> Unfortunately the captions I tested the least due to the issue of them not working from the filesystem

[15:05:29 CST(-0600)] <Bosmon> Right now I am working on getting the test cases running again but if you can characterise the issue you see and write it up I can look at it later

[15:05:31 CST(-0600)] <michelled> you can see it on the build now - I just rebuilt

[15:06:03 CST(-0600)] <Bosmon> Btw, the bigger videos look really great

[15:06:05 CST(-0600)] <Bosmon> Thanks guys

[15:07:08 CST(-0600)] <alexn> the big videos look great but a standalone demo page in Chrome has some issues already told cindy about it

[15:07:20 CST(-0600)] <alexn> the video is smaller and there but cute

[15:08:28 CST(-0600)] <alexn> Bosmon: do you want me to write down the step by step how to replicate an issue I'm seeing with captions ? It is a weird one… not sure what causes it

[15:08:38 CST(-0600)] <Bosmon> Thanks, alexn, that would be helpful

[15:08:44 CST(-0600)] <michelled> alexn: I think it would be good if you create a JIRA issue for it

[15:08:58 CST(-0600)] <Bosmon> The cause is probably exposing some "jank" in the transfer of model material around the component tree

[15:09:06 CST(-0600)] <Bosmon> I had to remove a lot for both volume button and transcripts

[15:09:17 CST(-0600)] <Bosmon> Since there were lots of cases where the component state wasn't kept consistent with the model state

[15:09:24 CST(-0600)] <Bosmon> I probably need to do the same with the captions too

[15:09:45 CST(-0600)] <Bosmon> Everything sent by "direct relay" attached to the videoPlayer component at the model level, so its important for everything to bind directly to that

[15:09:49 CST(-0600)] <Bosmon> attaches

[15:13:15 CST(-0600)] <alexn> michelled, Bosmon: Creating a JIRA. Bosmon, is it OK if I assign it on your name? I'm writing a description how to replicate it.

[15:13:25 CST(-0600)] <Bosmon> alex - thanks, that's great

[15:13:44 CST(-0600)] <Bosmon> Could you add a reference to it in our big "TO DO" list too, thanks

[15:16:37 CST(-0600)] <alexn>

[15:16:38 CST(-0600)] <Bosmon> Ah, I see now what happened in the test cases... I missed some references to this "activatedByKeyboard" event which I was destroying....

[15:16:56 CST(-0600)] <alexn> I will put it into the TO DO list as well

[15:17:10 CST(-0600)] <alexn> thanks for looking into it Bosmon, you are the best ! (smile)

[15:17:21 CST(-0600)] <michelled> alexn: make it red please (smile)

[15:18:44 CST(-0600)] <Bosmon> We will see if I am the best : P

[15:19:01 CST(-0600)] <Bosmon> I am also tempted to get rid of this "modelPath" business I see everywhere but it would be impolite to do it without a proper discussion....

[15:21:24 CST(-0600)] <alexn> Go team Bosmon !

[15:21:34 CST(-0600)] <alexn> (smile)

[15:21:36 CST(-0600)] <cindyli> lol

[15:22:52 CST(-0600)] <cindyli> michelled, Bosmon: i noticed another regression, on the transcript area, switch the language in the dropdown list, the language selection on the popup menu from the transcript toggle button doesn't switch accordingly

[15:23:38 CST(-0600)] <cindyli> I should be able to fix it, but I'm not sure if I would do something that's against Bosmon's "modelPath" clean-up

[15:29:57 CST(-0600)] <Bosmon> I found the source of one bug... the "toggleView" callback in MenuButton makes a "return false"...

[15:30:08 CST(-0600)] <Bosmon> But this is actually registered as a listener to a preventable effect

[15:30:19 CST(-0600)] <Bosmon> So further listeners are not consulted

[15:31:03 CST(-0600)] <Bosmon> cindyli - can you describe that bug in more detail?

[15:31:05 CST(-0600)] <Bosmon> I'm not sure I can see it

[15:31:14 CST(-0600)] <Bosmon> Which do you mean by the "dropdown list"?

[15:31:21 CST(-0600)] <Bosmon> Do you mean the one in the UIOptions panel?

[15:31:50 CST(-0600)] <Bosmon> Yes, I see it

[15:31:50 CST(-0600)] <cindyli> no, Bosmon, the dropdown on the transcript area

[15:31:58 CST(-0600)] <cindyli> nice

[15:32:08 CST(-0600)] <Bosmon> cindyli - how is "the dropdown in the transcript area" different from "the language selection on the popup menu"?

[15:32:16 CST(-0600)] <Bosmon> Oh I see

[15:32:19 CST(-0600)] <Bosmon> There is yet another dropdown

[15:32:20 CST(-0600)] <cindyli> haha

[15:32:26 CST(-0600)] <cindyli> ah, i see

[15:32:42 CST(-0600)] <Bosmon> But I see that the popup language state isn't updated by either of them

[15:32:48 CST(-0600)] <Bosmon> Just add that one to my list, I will look at it

[15:33:27 CST(-0600)] <cindyli> thanks, bosmon, let me know if you have too much on ur plate and want me to look at this

[15:33:52 CST(-0600)] <michelled> Bosmon: you hold all the red now so please feel free to pull us in where we can be useful

[15:34:23 CST(-0600)] <Bosmon> Ok, well I guess you will be mostly popping off home now : P

[15:34:39 CST(-0600)] <Bosmon> I'll push another branch tonight, so feel free to start cracking on anything I haven't dealt with in the morning : P

[15:34:48 CST(-0600)] <michelled> ok

[15:36:22 CST(-0600)] <Bosmon> I'm a bit worried about the failure of the fullscreen test

[15:36:30 CST(-0600)] <Bosmon> I assume that really was working yesterday?

[15:39:34 CST(-0600)] <michelled> Bosmon: I believe all the tests were passing yesterday

[15:39:37 CST(-0600)] <Bosmon> I get an exception on the " videoEl.webkitEnterFullScreen();" call in VideoPlayer.js

[15:39:43 CST(-0600)] <michelled> alexn worked on fullscreen

[15:40:10 CST(-0600)] <Bosmon> Line 440

[15:40:15 CST(-0600)] <michelled> Bosmon: it sounds like the test is browser dependent

[15:40:20 CST(-0600)] <michelled> I've been running in FF

[15:40:32 CST(-0600)] <michelled> it sounds like the test might need some work?

[15:40:53 CST(-0600)] <Bosmon> Ok, this is in Chrome

[15:41:02 CST(-0600)] <Bosmon> Visually it looks like the video element hasn't rendered yet

[15:41:08 CST(-0600)] <Bosmon> Which might be the cause of the exception

[15:41:09 CST(-0600)] <alexn> I think the tests were written for the old fullscreen functionality

[15:41:10 CST(-0600)] <Bosmon> I'll try it in FF

[15:41:55 CST(-0600)] <Bosmon> Although I notice these days that everything is running REALLY slowly in FF

[15:41:58 CST(-0600)] <Bosmon> I've pretty much abandoned it

[15:42:06 CST(-0600)] <Bosmon> Ok

[15:42:09 CST(-0600)] <Bosmon> The test runs for me in FF

[15:42:17 CST(-0600)] <Bosmon> Is it ok if I punt that one to you guys?

[15:42:29 CST(-0600)] <Bosmon> I'll get the others working this evening

[15:42:33 CST(-0600)] <alexn> I just tried

[15:42:35 CST(-0600)] <alexn> in Chrome

[15:42:40 CST(-0600)] <alexn> and fullscreen worked fine

[15:42:51 CST(-0600)] <Bosmon> Yes, it works, but it seems that the test doesn't

[15:42:51 CST(-0600)] <alexn> or we are talking about the tests in videoPlayer ?

[15:42:55 CST(-0600)] <Bosmon> tests, yes

[15:43:13 CST(-0600)] <Bosmon> Test throws an exception, seemingly due to a timing issue as a result of the video not being rendered in time

[15:43:21 CST(-0600)] <alexn> well tests are super old. I'm pretty sure that fullscreen functionality was completely broken till 2 days ago

[15:43:35 CST(-0600)] <alexn> when we put a completely different implementation

[15:43:45 CST(-0600)] <alexn> I think we should take out those fullscreen tests for now

[15:43:45 CST(-0600)] <Bosmon> Ok, well I put getting the test working in Chrome again on your plate (smile)

[15:43:55 CST(-0600)] <alexn> alright !

[15:43:57 CST(-0600)] <alexn> (smile)

[15:44:26 CST(-0600)] <Bosmon> No reason to throw them out, if they run on at least one browser...

[15:44:29 CST(-0600)] <Bosmon> Clearly they are testing something!

[15:44:57 CST(-0600)] <alexn> I'm really surprised that this fullscreen test work at all

[15:45:06 CST(-0600)] <alexn> (big grin)

[15:45:14 CST(-0600)] <alexn> because functionality is completely different

[15:45:26 CST(-0600)] <alexn> it is like taking a person who tests cars and ask him to test the wine

[15:45:29 CST(-0600)] <Bosmon> I'm surprised that many of the things in VideoPlayer work at all, given the giant tangled ball of string of its logic : P

[15:45:30 CST(-0600)] <alexn> (tongue)

[15:45:36 CST(-0600)] <alexn> yes

[15:45:39 CST(-0600)] <Bosmon> I am still trying to track down why on earth the toggle button actually triggers at all

[15:45:56 CST(-0600)] <alexn> great point. which means there are lots of code to be reviewed and reworked next week

[15:46:31 CST(-0600)] <Bosmon> But in general, the biggest overall issue is that there is a great lack of "model idiom" throughout the entire component

[15:46:44 CST(-0600)] <Bosmon> Whilst most parts of the logic HAVE a model, most of the time they are not paying attention to it

[15:47:30 CST(-0600)] <Bosmon> "A model isn't just for Christmas"!

[15:47:33 CST(-0600)] <alexn> Bosmon: could you please make few quick notes of anything you see odd. on a piece of paper in a notepad. Because we are going to address every single issue at some point

[15:47:58 CST(-0600)] <alexn> well any kid wants to celebrate Christmas every day (wink)

[15:48:06 CST(-0600)] <Bosmon> Well, we should start to get back to JIRAing things soon

[15:48:15 CST(-0600)] <alexn> big times !

[15:48:17 CST(-0600)] <Bosmon> Due to the very large number of issues and small time to address them in, we have been doing this informally

[15:48:29 CST(-0600)] <Bosmon> But once the current panic ends, every remaining issue should have a proper JIRA

[15:49:38 CST(-0600)] <michelled> Bosmon: I noticed that things got really slow overnight - I thought it might be due to logging

[15:49:59 CST(-0600)] <Bosmon> Well, things are incredibly slow on FF - it think due to the way UIO dispatches events

[15:50:13 CST(-0600)] <Bosmon> I think I mentioned the architectural problem it has that "every change broadcasts to every listener"

[15:50:35 CST(-0600)] <Bosmon> So using any of the UIO controls causes a lot of event slop rushing around the page

[15:50:48 CST(-0600)] <Bosmon> Do you notice any other things being slow?

[15:56:54 CST(-0600)] <michelled> Bosmon: it's just slow to load the page

[15:56:59 CST(-0600)] <michelled> a lot slower than it used to be

[15:57:04 CST(-0600)] <michelled> I haven't looked at why p

[15:57:16 CST(-0600)] <michelled> perhaps cindyli and I can take a look tomorrow

[15:58:39 CST(-0600)] <Bosmon> ok

[15:58:56 CST(-0600)] <Bosmon> I suspect a lot of that, again, is the event broadcast between UIO and the child components

[15:59:19 CST(-0600)] <Bosmon> There should be some "anti-jank" in there but I suspect it is not working correctly since the video players seem to initialise earlier than expected

[15:59:29 CST(-0600)] <Bosmon> Or else UIO gets its configuration from settings slower than expected

[15:59:43 CST(-0600)] <Bosmon> So there is a stream of events broadcast from it to all the video players after it loads the cookie

[16:02:28 CST(-0600)] <Bosmon> michelled - actually I wonder if you could explain these tests to me a bit

[16:02:53 CST(-0600)] <Bosmon> So the first one that is failing is called, "selecting show/hide shows menu"

[16:03:07 CST(-0600)] <Bosmon> But as I understand it now, show/hide in this description is actually ONE OF THE MENU ITEMS

[16:03:17 CST(-0600)] <Bosmon> So how is it that it might cause the menu that it is a part of to be shown?

[16:03:21 CST(-0600)] <Bosmon> Is this right?

[16:03:36 CST(-0600)] <Bosmon> I had assumed that show/hide referred to the toggle button for the menu, but it seems it isn't

  • No labels