Skip to end of metadata
Go to start of metadata

[10:32:44 CDT(-0500)] <anastasiac> fluid-everyone: are we having stand-up today?

[12:21:08 CDT(-0500)] <michelled> anastasiac: I added an access key of 'S' for the skip to link

[12:21:17 CDT(-0500)] <michelled> anastasiac: what do you think? https://github.com/michelled/OER-Commons/compare/ISKME:master...607

[12:23:04 CDT(-0500)] <anastasiac> seems reasonable, michelled. how does it actually work? just press 's' when focus is on that link? is it case sensitive? does it work in all browsers?

[12:23:50 CDT(-0500)] <michelled> anastasiac: you need to use a different modifier for different browsers. see the table on this page: http://en.wikipedia.org/wiki/Access_key

[12:24:49 CDT(-0500)] <michelled> anastasiac: it doesn't work in Safari because the skip to link doesn't work in Safari

[12:25:17 CDT(-0500)] <anastasiac> michelled, does the access key bring focus to the skip to link, or to the target of the skip to link?

[12:25:31 CDT(-0500)] <michelled> it activates the link

[12:26:05 CDT(-0500)] <anastasiac> michelled, does the key work when focus is not actually on the link?

[12:26:30 CDT(-0500)] <michelled> anastasiac: yes

[12:26:57 CDT(-0500)] <anastasiac> is 's' an typical key for this link?

[12:27:16 CDT(-0500)] <anastasiac> are there any guidelines for that?

[12:27:26 CDT(-0500)] <michelled> anastasiac: yes, if you look lower on that page, you'll see it's recommended by the UK government

[12:27:35 CDT(-0500)] <michelled> anastasiac: I don't know if there are other recommendations

[12:30:35 CDT(-0500)] <anastasiac> michelled, did you check the WebAIM page? http://webaim.org/techniques/keyboard/accesskey

[12:31:20 CDT(-0500)] <michelled> anastasiac: they refer to the same standard, right?

[12:31:43 CDT(-0500)] <anastasiac> yes, seems so. the page talks about possible conflicts with other access keys, etc

[12:32:03 CDT(-0500)] <anastasiac> there's also a link the canadian gov't recommendations, interestingly

[12:32:15 CDT(-0500)] <michelled> that's expected anastasiac - groggy still felt like it was worth having an access key

[12:32:34 CDT(-0500)] <michelled> oh spell correct (sad) I meant Greg

[12:32:46 CDT(-0500)] <anastasiac> oh yes, I'm just wondering if there's anything there to suggest the best letter

[12:33:30 CDT(-0500)] <anastasiac> I could see 's' being used for 'submit'

[12:40:29 CDT(-0500)] <anastasiac> michelled, regarding 606, the ISMKE link. I agree, it probably makes sense to remove one of the links from the tab order. I'd guess it would be better to remove the logo, and keep the one that's in a sentence - the sentence adds context that would be helpful. What do you think?

[12:41:00 CDT(-0500)] <michelled> anastasiac: I agree

[12:41:29 CDT(-0500)] <anastasiac> michelled, are you ok with me submitting the pull requests as is with the 'tab index="-1"' added, or do you want to double-check it?

[12:41:47 CDT(-0500)] <michelled> you can go ahead anastasiac

[12:41:52 CDT(-0500)] <anastasiac> thanks

[12:57:13 CDT(-0500)] <anastasiac> michelled, my 604-skip-tags branch has been updated to add the 'skip tags' link to the green pages: https://github.com/acheetham/OER-Commons/tree/604-skip-tags I still can't tell where that page in the tags app gets used. Sergey says the tags app is a form used for added tags, but that refers to the other template, not the one that lists the tag cloud

[12:58:28 CDT(-0500)] <michelled> ok, good to know

[12:58:44 CDT(-0500)] <michelled> we'll have to keep an eye out for it once we have a test plan for oercommons

[13:00:00 CDT(-0500)] <michelled> anastasiac: the after-tags anchor - was it being put in tab order before you added the tab index?

[13:00:15 CDT(-0500)] <michelled> I thought if there was no href anchors didn't get into tab order

[13:01:48 CDT(-0500)] <anastasiac> michelled, in general, no, but it was causing problems in IE: without the tab index of -1, focus was being thrown elsewhere in the page. I did a bit of research, and removing it from the tab order seems to be the recommended solution

[13:10:08 CDT(-0500)] <michelled> anastasiac: good to know - any idea where focus was being thrown?

[13:10:50 CDT(-0500)] <anastasiac> depended where the link was, michelled; basically up before the 'skip tags' link, which obviously isn't helpful (smile)

[13:11:09 CDT(-0500)] <michelled> which IE was that?

[13:11:18 CDT(-0500)] <anastasiac> both 8 and 9

[13:11:38 CDT(-0500)] <michelled> even 9 - oh well

[13:11:48 CDT(-0500)] <michelled> anastasiac: I think you should go ahead with your pull request to staging

[13:12:12 CDT(-0500)] <anastasiac> k, thanks michelled

[13:12:20 CDT(-0500)] <michelled> np

[13:46:08 CDT(-0500)] <anastasiac> michelled, I'm just looking at 609, the required fields in the profile. Can you clarify just which profile you're referring to?

[14:00:22 CDT(-0500)] <michelled> anastasiac: this came out of one of greg's findings

[14:02:11 CDT(-0500)] <anastasiac> michelled, since I'm not in the office, could you double-check this one with greg for me? I'm looking at the profile page, and there are no asterixes, so I'm not sure I'm looking at the right page

[14:02:31 CDT(-0500)] <michelled> have you clicked on the gear?

[14:02:38 CDT(-0500)] <michelled> also, are you looking at master or staging?

[14:03:20 CDT(-0500)] <anastasiac> checking local. yes, the gear shows one field with an asterix - is that the only one field? I see problems with other fields that are required but have no indication whatsoever, but no other asterixes

[14:03:26 CDT(-0500)] <anastasiac> local = master

[14:04:43 CDT(-0500)] <michelled> anastasiac: greg tested staging and there are a lot more required fields on staging

[14:05:13 CDT(-0500)] <anastasiac> ah, interesting. Not sure how to process this one, michelled, with the request that we base our branches on master

[14:05:54 CDT(-0500)] <michelled> maybe it's a case where you need to make two branches - one that fixes staging and one that fixes master

[14:06:46 CDT(-0500)] <anastasiac> wow, staging is quite different from master - the whole section is being redesigned, michelled

[14:12:20 CDT(-0500)] <anastasiac> michelled, it looks like the account settings stuff is undergoing a reorganization: https://www.assembla.com/spaces/iskme/tickets/491 I wonder how we should handle that? there doesn't seem much point in working on master if it's going to be completely redone. Perhaps just work with staging? Try to get fixes in before they push to master?

[14:15:05 CDT(-0500)] <michelled> anastasiac: maybe you should put recommendations on their ticket

[14:15:15 CDT(-0500)] <michelled> code samples if they are useful

[14:15:27 CDT(-0500)] <anastasiac> sounds good, michelled

[14:15:30 CDT(-0500)] <michelled> anastasiac: that way Sergey or Andrey can do the work

[14:15:35 CDT(-0500)] <anastasiac> right

[14:49:04 CDT(-0500)] <avtar> anastasiac, michelled: ping

[14:49:16 CDT(-0500)] <anastasiac> avtar: pong

[14:50:15 CDT(-0500)] <avtar> the inclusivedesign.ca site was composed of three repos.. is that the case with dev.studios.fluidproject.org as well?

[14:51:42 CDT(-0500)] <anastasiac> no, avtar, that's not the case for studios

[14:52:07 CDT(-0500)] <anastasiac> checking

[14:52:42 CDT(-0500)] <anastasiac> avtar, for studios, the entire site is in one repo: https://github.com/fluid-project/studios.fluidproject.org

[14:52:57 CDT(-0500)] <anastasiac> with development and master branches

[14:53:01 CDT(-0500)] <avtar> ok thanks (smile)

  • No labels