Skip to end of metadata
Go to start of metadata

[08:04:24 CDT(-0500)] <michelled> good morning alexn

[08:05:18 CDT(-0500)] <alexn> gmorning

[08:06:00 CDT(-0500)] <alexn> going to do couple of FLOE thingies right now. time to clean up few things

[08:06:49 CDT(-0500)] <michelled> alexn: cool - I was just looking at your branches for OER Commons and I have a couple questions

[08:06:56 CDT(-0500)] <alexn> yes (smile)

[08:07:59 CDT(-0500)] <michelled> in OER-714 you've changed the border radius and box shadow to be relative to font size - does that still look ok when you max out the text size?

[08:08:02 CDT(-0500)] <michelled> I haven't tested it

[08:08:29 CDT(-0500)] <alexn> I tested every single of the submitted jiras. But give me a second to take a look at 714

[08:08:54 CDT(-0500)] <alexn> by taking a look I mean open the JIRA and open my pull request to see what is about since I submitted two of them

[08:09:40 CDT(-0500)] <alexn> actually give me 1 minute to finish this tiny pull request I'm doing

[08:09:48 CDT(-0500)] <michelled> take your time (smile)

[08:10:22 CDT(-0500)] <alexn> https://github.com/fluid-project/videoPlayer/pull/55 this is the JIRA you asked me to submit a pull request with what is working and what I currently have

[08:10:28 CDT(-0500)] <alexn> it is for FLUID-4748

[08:10:42 CDT(-0500)] <alexn> a tiny improvement but still an improvement

[08:11:33 CDT(-0500)] <alexn> changed Floe page as well to have the pull request there

[08:11:40 CDT(-0500)] <alexn> ok let me take a look at OER-714

[08:11:44 CDT(-0500)] <michelled> cool

[08:12:00 CDT(-0500)] <michelled> https://www.assembla.com/spaces/iskme/tickets/714

[08:12:09 CDT(-0500)] <michelled> 714 is about input sizes

[08:12:27 CDT(-0500)] <michelled> it looks to me like you've done the right thing and made the input sizes relative

[08:12:49 CDT(-0500)] <michelled> what I'm wondering about, is how it looks to have the box shadow and border radius relative too

[08:12:57 CDT(-0500)] <alexn> oh it looks good

[08:13:26 CDT(-0500)] <alexn> well it looks like nothing changed but input got bigger. this effect because shadow got bigger with input

[08:13:31 CDT(-0500)] <alexn> so they both look natural

[08:14:01 CDT(-0500)] <alexn> I think I tried to leave shadow as it is but then it looks a bit "unnatural" when you increase sizes

[08:14:04 CDT(-0500)] <alexn> like something is off

[08:14:35 CDT(-0500)] <alexn> it is the shadow which is within the input

[08:14:50 CDT(-0500)] <michelled> ok, cool - I think you should go ahead with the pull request to staging for 714

[08:15:07 CDT(-0500)] <alexn> ok will do

[08:15:17 CDT(-0500)] <alexn> and let me know if there is anything off with 720

[08:15:42 CDT(-0500)] <michelled> I do have a question about 720 - it's the one relating to open author table of contents

[08:15:59 CDT(-0500)] <michelled> did you test viewing resources that had been created in open author with your changes in?

[08:16:21 CDT(-0500)] <alexn> no I did not… are those pages affected ?

[08:16:44 CDT(-0500)] <michelled> some of the templates are shared between authoring and view for open author

[08:16:54 CDT(-0500)] <michelled> I haven't tested it, but I wanted to make sure you had

[08:17:04 CDT(-0500)] <alexn> well from what I saw those CSS rules are only for About and Help pages

[08:17:11 CDT(-0500)] <alexn> for their content

[08:17:18 CDT(-0500)] <alexn> not sure how Open Author ties in here

[08:17:33 CDT(-0500)] <alexn> but I can double check if anything is off there

[08:18:30 CDT(-0500)] <michelled> hmmm.... maybe I'm mixing up issues

[08:18:38 CDT(-0500)] <alexn> I see that Open Author has class authoring but not information as in the case of Help/About pages

[08:19:41 CDT(-0500)] <alexn> I do not see those pages being affected

[08:20:03 CDT(-0500)] <alexn> they have totally different CSS classes. Is there any problem with them which I do not see ? :S

[08:21:20 CDT(-0500)] <alexn> michelled: do I need to submit those OER issues this week or next week ?

[08:23:12 CDT(-0500)] <michelled> alexn: you're right 720 is fine (smile) I'm not sure which branch I was looking at

[08:23:36 CDT(-0500)] <michelled> alexn: go ahead and do the pull requests when ever you are working on Floe - no point keeping them out if you have fixes for them

[08:23:47 CDT(-0500)] <michelled> they'll just get farther from master

[08:23:55 CDT(-0500)] <michelled> pull requests to staging of course

[08:24:49 CDT(-0500)] <alexn> michelled: ok will do ! (smile) I'm also getting intact my fullscreen pull requests

[08:48:51 CDT(-0500)] <michelled> good morning anastasiac

[08:49:01 CDT(-0500)] <anastasiac> good morning, michelled

[08:49:10 CDT(-0500)] <michelled> not sure if you saw that Andrey K. had another question on the assembla ticket

[08:49:57 CDT(-0500)] <anastasiac> nope, haven't checked that yet - thanks for the heads-up

[08:50:19 CDT(-0500)] <michelled> np

[09:18:07 CDT(-0500)] <Justin_o> jhung: do we have this documented anywhere on the wiki http://issues.fluidproject.org/browse/DECA-267

[09:25:33 CDT(-0500)] <jhung> In the release notes since Decapod 0.5 we've mentioned this bug.

[09:26:12 CDT(-0500)] <jhung> ^justin_o

[09:26:31 CDT(-0500)] <Justin_o> jhung: excellent, thanks.. i'll close it off then

[14:41:33 CDT(-0500)] * chalcedony waves

[14:56:31 CDT(-0500)] <chalcedony> hi michelled

[14:56:42 CDT(-0500)] <michelled> hi chalcedony

[14:57:08 CDT(-0500)] <chalcedony> i heard about this project at the fcc event

[14:57:18 CDT(-0500)] <michelled> ah cool - how's the event going?

[14:57:39 CDT(-0500)] <chalcedony> beautifully

[14:58:56 CDT(-0500)] <michelled> what have you been up to at the event, chalcedony?

[14:59:17 CDT(-0500)] <Justin_o> jhung: is this something we still want to support http://issues.fluidproject.org/browse/DECA-119

[14:59:55 CDT(-0500)] <chalcedony> i'm watching online

[15:01:22 CDT(-0500)] <michelled> chalcedony: did you want to know more about anything we do here?

[15:01:40 CDT(-0500)] <chalcedony> yes

[15:01:52 CDT(-0500)] <chalcedony> i'm watching the q/a session

[15:02:12 CDT(-0500)] <chalcedony> www.fcc.gov/live

[15:02:46 CDT(-0500)] <michelled> thanks for the link!

[15:03:23 CDT(-0500)] <chalcedony> your job will be to interface between consumers and applications and devices to provide more optimal services?

[15:06:03 CDT(-0500)] <jhung> No recalibration for now justin_o.

[15:06:25 CDT(-0500)] <Justin_o> jhung: okay.. should we close that one or push it.. i guess we can talk about it later

[15:06:31 CDT(-0500)] <michelled> yes, the GPII will provide a means for services to be delivered to consumers based on availability of services and the needs, preferences and context of the user

[15:06:35 CDT(-0500)] <jhung> Remove the "fix version" from 0.7 I think

[15:06:53 CDT(-0500)] <jhung> push it. Worth having it documented justin_o

[15:06:55 CDT(-0500)] <chalcedony> sounds very cool

[15:07:19 CDT(-0500)] <chalcedony> will there be ways to protect the person's privacy so not everyone knows they have disabilities?

[15:07:21 CDT(-0500)] <Justin_o> jhung: okay

[15:07:39 CDT(-0500)] <michelled> chalcedony: yes, that is one of the most important things being considered

[15:07:58 CDT(-0500)] <jhung> justin_o: I'll edit that Jira now

[15:08:18 CDT(-0500)] <michelled> no one should know that a particular user has a disability

[15:08:28 CDT(-0500)] <yura1> chalcedony: at this point we will most likely not tie a particular user preferences profile to a person

[15:08:42 CDT(-0500)] <jhung> justin_o: forgot we had a "future" version. So I used that instead.

[15:09:15 CDT(-0500)] <Justin_o> jhung: thanks.. that makes sense.. i forgot about that too (smile)

[15:10:04 CDT(-0500)] <Justin_o> jhung: i've added all the open jiras to this page http://wiki.fluidproject.org/display/fluid/Decapod+0.7+Planning

[15:10:12 CDT(-0500)] <Justin_o> that way we can review them when we do our planning

[15:35:43 CDT(-0500)] <chalcedony> michelled, open adobe is i think who is speaking now

[15:35:53 CDT(-0500)] <chalcedony> i'm glad you have an irc channel

[15:36:45 CDT(-0500)] <chalcedony> i think they just got two points to address. 1. who is speaking? 2. who is waiting to speak?

[15:37:51 CDT(-0500)] <chalcedony> issue of what person has the floor and whose voice is heard.. using an interpreter

[15:38:56 CDT(-0500)] <michelled> chalcedony: yeah, irc is pretty great - we've often found that it works best in many situations

[15:39:11 CDT(-0500)] <chalcedony> (smile)

[15:39:14 CDT(-0500)] <michelled> we always know who has the floor in here (wink)

[15:39:19 CDT(-0500)] <chalcedony> right on

[15:39:24 CDT(-0500)] <chalcedony> text is best!

[15:39:45 CDT(-0500)] <chalcedony> people get too used to using their mouths

[15:40:25 CDT(-0500)] <michelled> we've also found that having it logged on our wiki is really useful - that way we get to go back over decisions and people in different time zones can still follow along when they wake up

[15:40:40 CDT(-0500)] <chalcedony> i will admit that CCAC recently tried an event using google's new captioning program

[15:40:53 CDT(-0500)] <michelled> how did it work?

[15:41:08 CDT(-0500)] <chalcedony> there were problems with individual equipment

[15:41:28 CDT(-0500)] <chalcedony> one gentleman didn't have sound in his laptop and his microphone was not good

[15:41:40 CDT(-0500)] <chalcedony> i couldn't get the caption portion on my screen

[15:41:48 CDT(-0500)] <chalcedony> not if i had the chat open

[15:42:02 CDT(-0500)] <chalcedony> i restarted firefox twice

[15:42:20 CDT(-0500)] <chalcedony> overall it was a lot of fun for everyone

[15:42:36 CDT(-0500)] <chalcedony> profoundly deaf people enjoyed the captioning

[15:42:37 CDT(-0500)] <michelled> that sounds very positive

[15:42:57 CDT(-0500)] <chalcedony> none of them know irc

[15:43:12 CDT(-0500)] <chalcedony> they are using things like facebook

[15:44:39 CDT(-0500)] <chalcedony> CCAC is captioning advocacy

[15:45:53 CDT(-0500)] <chalcedony> http://www.facebook.com/ccac.captioning?ref=tn_tnmn

[15:46:34 CDT(-0500)] <chalcedony> Subscribe to newsletter http://http://ccacaptioning.org/subscribe/

[15:46:34 CDT(-0500)] <chalcedony> Join CCAC Membership Community

[15:46:34 CDT(-0500)] <chalcedony> http://ccacaptioning.org/join/

[15:46:47 CDT(-0500)] <michelled> thanks for the links chalcedony

[15:47:29 CDT(-0500)] <chalcedony> no problem

[15:47:38 CDT(-0500)] <chalcedony> i'm finding out so much about all of this

[15:48:24 CDT(-0500)] <chalcedony> my husband, who was a computer professional, had a stroke in 1999 and lost his ability to understand speech and speak. he can read

[15:49:03 CDT(-0500)] <michelled> oh wow, that must have been difficult for you both

[15:49:57 CDT(-0500)] <chalcedony> i have different disabilities - yes it is

[15:50:32 CDT(-0500)] <chalcedony> writing and typing are our best communication mediums

[15:53:47 CDT(-0500)] <michelled> are there particular tools you prefer to use?

[15:54:38 CDT(-0500)] <chalcedony> for my husband everything is input, he can't speak, write words or type (can't remember how things are spelled)

[15:54:51 CDT(-0500)] <chalcedony> he pastes words to make documents

[15:54:57 CDT(-0500)] <chalcedony> shopping lists etc

[15:55:13 CDT(-0500)] <michelled> interesting

[15:55:28 CDT(-0500)] <chalcedony> expressive aphasia is tough

[15:55:35 CDT(-0500)] <chalcedony> everyone is so different

[15:55:41 CDT(-0500)] <chalcedony> there are no 'standard aids'

[15:55:50 CDT(-0500)] <chalcedony> we got a dynavox

[15:56:18 CDT(-0500)] <chalcedony> but the programming for it is each individual case, and you can't say make a dialogue for this doctor's appontment

[15:56:32 CDT(-0500)] <chalcedony> you could make a generic thing for a dining room

[15:56:59 CDT(-0500)] <chalcedony> also - the training for it is in groups for people who can hear and speak.

[15:57:26 CDT(-0500)] <chalcedony> i talk but have auditory comprehension problems

[15:57:58 CDT(-0500)] <chalcedony> when we tried it (i haven't looked for a while) all of their training was uncaptioned videos

[15:58:32 CDT(-0500)] <michelled> hmmm…. seems like a huge gap in aids for learning their system

[15:58:40 CDT(-0500)] <chalcedony> it's easier to type a letter to the doctor discussing the issues he wants to talk about

[15:58:56 CDT(-0500)] <chalcedony> then he can correct me

[15:59:07 CDT(-0500)] <chalcedony> his doctor is quite good to read the laptop

[16:00:07 CDT(-0500)] <chalcedony> we just got a CaptionCall phone

[16:00:25 CDT(-0500)] <chalcedony> which, if i have a voice conversation he can read the other party's words

[16:00:45 CDT(-0500)] <chalcedony> it doesn't caption my words

[16:02:22 CDT(-0500)] <chalcedony> it's a great help though for him to at least know what the other people said

[16:03:27 CDT(-0500)] <michelled> how good is the captioning of what the other people say?

[16:03:53 CDT(-0500)] <chalcedony> it's live captioning (the man who installed it didn't know that)

[16:04:27 CDT(-0500)] <chalcedony> i tried one time and got that they didn't have an available captionist, try later

[16:04:56 CDT(-0500)] <michelled> oh, wow - is the service 24 hour?

[16:05:14 CDT(-0500)] <chalcedony> i honestly don't believe they will be able to get 100% accurate captioning without people in the interface

[16:05:37 CDT(-0500)] <michelled> I think you're right about that - at least not any time soon

[16:05:40 CDT(-0500)] <chalcedony> google captions misses all the words that hearing impaired people miss.. it makes a horrible mess

[16:05:57 CDT(-0500)] <michelled> yes

[16:06:24 CDT(-0500)] <chalcedony> the FCC pays for captioning companies to caption live phone anywhere in the usa

[16:06:25 CDT(-0500)] <michelled> chalcedony: do you have a link to the google service you were mentioning before?

[16:06:35 CDT(-0500)] <chalcedony> hmmm

[16:06:55 CDT(-0500)] <chalcedony> i've just seen it on some videos that say they are captioned, little red box at the bottom with CC

[16:07:08 CDT(-0500)] <chalcedony> and then you agree to google captions beta

[16:07:25 CDT(-0500)] <chalcedony> let's see if we can find it?

[16:08:24 CDT(-0500)] <chalcedony> https://support.google.com/youtube/bin/static.py?hl=en&amp;page=guide.cs&amp;guide=2734661 YouTube

[16:08:47 CDT(-0500)] <chalcedony> https://support.google.com/youtube/bin/answer.py?hl=en&amp;answer=100076

[16:09:08 CDT(-0500)] <chalcedony> Universal Subtitles link on this page is Amara - they were present there today

[16:09:50 CDT(-0500)] <michelled> ah yes - we collaborate with them on a couple projects

[16:10:04 CDT(-0500)] <chalcedony> cool

[16:10:22 CDT(-0500)] <chalcedony> i heard about them through CCAC

[16:10:47 CDT(-0500)] <chalcedony> i have some people who are thinking about being interested in captioning in different languages

[16:13:58 CDT(-0500)] <michelled> I love the idea of crowd sourcing this stuff - it takes the burden off the original creator and makes the content accessible to so many more people

[16:14:29 CDT(-0500)] <chalcedony> i'm not familiar with the term 'crowdsourcing' ?

[16:15:15 CDT(-0500)] <colinclark> alexn: You here for a few minutes longer?

[16:16:25 CDT(-0500)] <colinclark> I had a quick review question I was going to ask you here, but I don't want to distract you if you're on your way out

[16:16:27 CDT(-0500)] <colinclark> shouldn't take long

[16:16:44 CDT(-0500)] <alexn> colinclark: I was about to ask - what pull request is this ? (big grin)

[16:16:55 CDT(-0500)] <colinclark> Tell me about line 443 here: https://github.com/fluid-project/videoPlayer/pull/56/files

[16:17:33 CDT(-0500)] <michelled> chalcedony: basically getting a lot of people to do a little work in order to get a big task done: http://en.wikipedia.org/wiki/Crowdsourcing

[16:17:41 CDT(-0500)] <alexn> oh I know. initially I wanted to do requestFullScreen()

[16:17:55 CDT(-0500)] <alexn> but it does not work in FF (not sure about other browsers) it would give me an error

[16:18:08 CDT(-0500)] <colinclark> ok

[16:18:12 CDT(-0500)] <alexn> I was trying to find more information about it but could not find a solution

[16:18:12 CDT(-0500)] <colinclark> Do you know why it didn't work?

[16:18:36 CDT(-0500)] <alexn> (smile) still looking for it

[16:18:43 CDT(-0500)] <colinclark> ok, I can explain

[16:18:48 CDT(-0500)] <alexn> all ears

[16:19:09 CDT(-0500)] <colinclark> So, at least in some browsers, DOM nodes are "this-ist" objects

[16:19:30 CDT(-0500)] <colinclark> You've perhaps read Crockford's JavaScript book or this article: http://fluidproject.org/blog/2008/07/21/about-this-and-that/

[16:19:56 CDT(-0500)] <colinclark> In other words, such methods aren't bound to their object instances

[16:20:21 CDT(-0500)] <colinclark> So when you're holding on to a method as a function pointer and invoke it directly, it doesn't have a "this"

[16:20:55 CDT(-0500)] <colinclark> So it looks like what you're doing with your line of code there is to grab the functions name, look it up on the Video element, and invoke it in the context of that object.

[16:20:59 CDT(-0500)] <colinclark> It works

[16:21:03 CDT(-0500)] <colinclark> it's just a bit contrived

[16:21:21 CDT(-0500)] <colinclark> alexn: Meet your new friend, Function.apply(): https://developer.mozilla.org/en-US/docs/JavaScript/Reference/Global_Objects/Function/apply

[16:22:17 CDT(-0500)] <alexn> interesting.

[16:23:26 CDT(-0500)] <colinclark> Given a Function instance, you can invoke it using apply() and specify the "this" context

[16:25:06 CDT(-0500)] <alexn> sweet ! I will take a look into it

[16:26:40 CDT(-0500)] <colinclark> If you can update the pull request with that, I will push it

[16:27:33 CDT(-0500)] <colinclark> I don't want to get all Linus-y on you, but I'd prefer it also if you could break the long || statement on line 442 onto a second line, just so it's a bit easier to read

[16:27:36 CDT(-0500)] <chalcedony> michelled, i see thank you (smile)

[16:30:41 CDT(-0500)] <michelled> np

[16:31:58 CDT(-0500)] <alexn> colinclark: https://github.com/fluid-project/videoPlayer/pull/56/files what do you think (smile)

[16:32:42 CDT(-0500)] <colinclark> alexn: What does our JSLint instance say? http://swarm.fluidproject.org/jslint/

[16:35:46 CDT(-0500)] <alexn> colinclark: JSLint found few things here and there but nothing related to the pull request

[16:36:23 CDT(-0500)] <Bosmon> For those particular lines, alexn, as a courtesy I would move the feature detect out of the line of the function call itself

[16:36:34 CDT(-0500)] <Bosmon> Given it is clearly impossible for the result to change over the lifetime of the code

[16:37:29 CDT(-0500)] <colinclark> Bosmon: I don't understand your comment

[16:37:44 CDT(-0500)] <colinclark> Ah

[16:37:48 CDT(-0500)] <colinclark> I think I do

[16:37:55 CDT(-0500)] <alexn> colinclark Bosmon: sorry I'm still not (smile)

[16:38:02 CDT(-0500)] <colinclark> Ok

[16:38:08 CDT(-0500)] <colinclark> So, if you think about it…

[16:38:15 CDT(-0500)] <colinclark> Feature detection is static

[16:38:23 CDT(-0500)] <colinclark> You do it once, and then know you what the browser is capable of

[16:38:32 CDT(-0500)] <colinclark> it was the same issue in the previous code

[16:39:00 CDT(-0500)] <colinclark> Every time the user switches into full screen mode, the current code does the feature detection all over again

[16:39:05 CDT(-0500)] <Bosmon> So, here is a suggestive signature for you - that.requestFullScreen = fluid.makeFullScreenMethod(videoEl);

[16:39:53 CDT(-0500)] <Bosmon> The miracle of "higher order functions" sent to us by holy transmission from the 1960s and Lisp....

[16:39:59 CDT(-0500)] <colinclark> lol

[16:40:32 CDT(-0500)] <alexn> colinclark Bosmon: I see (smile) sounds like another commit is comming

[16:40:52 CDT(-0500)] <colinclark> alexn: Do you see what I mean? Why pay the cost of figuring out which function to invoke each time, when you can do it once when the component is first created?

[16:40:56 CDT(-0500)] <colinclark> cool, alexn

[16:40:58 CDT(-0500)] <colinclark> looking forward to it

[16:41:29 CDT(-0500)] <Bosmon> You will see jquery pulling this kind of trick numerous times in its codebase

[16:41:52 CDT(-0500)] <Bosmon> Especially since it almost always prefers to choose the option which minimises codebase size at the cost of load-time execution

[16:43:08 CDT(-0500)] <Bosmon> And why not, since it is so absurdly easy in JavaScript.... in a language like Java or C#, this would most likely require "bytecode manipulation"....

[16:43:19 CDT(-0500)] <Bosmon> It's always a surprise how much of a falling-off there was since the 60s (smile)

[16:43:57 CDT(-0500)] <colinclark> For FLUID-4779, I'm a bit worried about this whole "fluid.browser" area of code-I realize you inherited it, alexn-but now might be a good time to proactively make some improvements

[16:44:07 CDT(-0500)] <colinclark> I guess we'll have to think it through a little bit

[16:44:08 CDT(-0500)] <colinclark> https://github.com/fluid-project/videoPlayer/pull/45/files

[16:44:17 CDT(-0500)] <Bosmon> As Elijah once said, "Now, O Lord, take my life; for I am not better than my fathers" : P

[16:44:34 CDT(-0500)] <colinclark> lol

[16:45:30 CDT(-0500)] <alexn> I do not remember reading about this in my "programming and algorithms" books (big grin)

[16:45:49 CDT(-0500)] <colinclark> It's interesting to see how many TODO comments are in this block of code: https://github.com/anvk/videoPlayer/blob/7b31fd3a741a608684738d4528033d226e4d1232/js/VideoPlayer.js#L28-57

[16:46:14 CDT(-0500)] <Bosmon> It can often take 50 to 100 years for the learning of our fathers to be uncovered again ....

[16:46:32 CDT(-0500)] <alexn> colinclark: means we have a bumpy road ahead (smile)

[16:46:59 CDT(-0500)] <colinclark> it's usually a sign to ponder what's here and do some proactive refactoring

[16:47:39 CDT(-0500)] <colinclark> Interestingly, it seems that Charly did IoC-ize the entire Controllers component

[16:47:42 CDT(-0500)] <colinclark> or someone since then

[16:48:40 CDT(-0500)] <alexn> colinclark: I guess this fluid.browser could be just a component as well for our videoPlayer

[16:48:49 CDT(-0500)] <colinclark> Perhaps

[16:48:53 CDT(-0500)] <alexn> I mean refactored into one

[16:49:09 CDT(-0500)] <Bosmon> I think Charly did succeed in understanding a reasonable amount about IoC before the end, yes

[16:49:18 CDT(-0500)] <colinclark> So there are a few things I'm pondering...

[16:49:31 CDT(-0500)] <colinclark> First is that the toggle button is actually a subcomponent of the Controllers component

[16:49:33 CDT(-0500)] <Bosmon> As I remember it was one of the reasons we decided to use his implementation rather than any of the others we could find by casting around

[16:50:06 CDT(-0500)] <colinclark> Second is that our feature detection code has been deliberately factored...

[16:50:14 CDT(-0500)] <Bosmon> Since even in its incomplete state it was already much more configurable "out of the box" than any other typical code

[16:50:44 CDT(-0500)] <colinclark> this is the key code: https://github.com/anvk/videoPlayer/blob/7b31fd3a741a608684738d4528033d226e4d1232/js/VideoPlayer.js#L45-50

[16:51:04 CDT(-0500)] <colinclark> You'll see that, if the browser has a particular feature, like, say, support for full screen mode

[16:51:09 CDT(-0500)] <colinclark> we actually create a "type tag"

[16:51:26 CDT(-0500)] <colinclark> A tiny component that we add to the static environment

[16:51:55 CDT(-0500)] <colinclark> So these names-type tags-are actually available to us to issue demands blocks against

[16:52:05 CDT(-0500)] <colinclark> So what I'm pondering, without yet having made a decision...

[16:52:25 CDT(-0500)] <colinclark> is why we are, after the components have all be created, hiding the full screen button with CSS

[16:52:48 CDT(-0500)] <Bosmon> Hopefully there is a comment against this type tag still, expressing the fact that it is a duplication risk against essentially the same thing in the Uploader

[16:53:16 CDT(-0500)] <colinclark> as opposed to using IoC to actually not even instantiate a full screen button in the first place

[16:53:31 CDT(-0500)] <colinclark> Bosmon: I don't think it's a duplication risk--the Uploader is very fine-grained about its feature detection

[16:53:38 CDT(-0500)] <Bosmon> Or is the other one in UIOptions

[16:53:42 CDT(-0500)] <colinclark> yes

[16:53:56 CDT(-0500)] <colinclark> I think I'm going to take a little tour through both the Uploader and UI Options to start seeing the patterns

[16:54:03 CDT(-0500)] <Bosmon> Yes, we have this fluid.browser.majorVersion thing in UIEnhancer

[16:54:12 CDT(-0500)] <Bosmon> As well as "fluid.hasFeature"

[16:54:35 CDT(-0500)] <colinclark> I'm not yet convinced I want to promote fluid.hasFeature()

[16:54:42 CDT(-0500)] <colinclark> but it's certainly worth having a look

[16:54:48 CDT(-0500)] <Bosmon> It should be destroyed, rather than promoted, yes (smile)

[16:55:24 CDT(-0500)] <colinclark> I was going to ask alexn why he decided to hide the full screen button with CSS instead of using IoC to not create it at all

[16:55:27 CDT(-0500)] <colinclark> but perhaps that can be for tomorrow

[16:55:34 CDT(-0500)] <colinclark> and for a comment in the pull request

[16:56:01 CDT(-0500)] <Bosmon> I'm sure yura can introduce him into the marvels of "fluid.emptySubcomponent"...

[16:56:13 CDT(-0500)] <colinclark> I suppose I will tomorrow

  • No labels